nwangtw commented on a change in pull request #3282: WIP STREAMCOMP-2724:
Stream Manager migrated to mainly use smart pointers instead of a manual memory
management
URL: https://github.com/apache/incubator-heron/pull/3282#discussion_r291281374
##########
File path: heron/common/src/cpp/metrics/tmaster-metrics.cpp
##########
@@ -35,7 +35,9 @@
namespace heron {
namespace common {
-TMasterMetrics::TMasterMetrics(const sp_string& sinks_filename, EventLoop*
eventLoop) {
+using std::shared_ptr;
Review comment:
the others use std::shared_ptr and here "using" is used. Better to be
consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
