nwangtw commented on a change in pull request #3310: Allow interpolate more
spout config parameters in extra links
URL: https://github.com/apache/incubator-heron/pull/3310#discussion_r301349854
##########
File path: heron/tools/tracker/src/python/config.py
##########
@@ -54,7 +57,7 @@ def load_configs(self):
if SPOUT_EXTRA_LINKS_KEY in self.configs:
for extra_link in self.configs[SPOUT_EXTRA_LINKS_KEY]:
- self.spout_extra_links[extra_link[SPOUT_TYPE_KEY]] =
[self.validate_extra_link(link) for link in extra_link[EXTRA_LINKS_KEY]]
+ self.spout_extra_links[extra_link[SPOUT_TYPE_KEY]] =
extra_link[EXTRA_LINKS_KEY]
Review comment:
why not need to validate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
