nwangtw commented on a change in pull request #3310: Allow interpolate more spout config parameters in extra links URL: https://github.com/apache/incubator-heron/pull/3310#discussion_r301350141
########## File path: heron/tools/config/src/yaml/tracker/heron_tracker.yaml ########## @@ -74,12 +77,12 @@ statemgrs: # - spout.type: "kafka" # extra.links: # - name: "Viz" -# formatter: "http://127.0.0.1/kafka/viz/${ENVIRON}-${CLUSTER}-${TOPOLOGY}-${SPOUT_NAME}-${SPOUT_SOURCE}"; +# formatter: "http://127.0.0.1/kafka/viz/${ENVIRON}-${CLUSTER}-${TOPOLOGY}-${spout.cluster}-${spout.source}"; # - name: "Alerts" -# formatter: "http://127.0.0.1/kafka/alerts/${ENVIRON}-${CLUSTER}-${TOPOLOGY}-${SPOUT_NAME}-${SPOUT_SOURCE}"; +# formatter: "http://127.0.0.1/kafka/alerts/${ENVIRON}-${CLUSTER}-${TOPOLOGY}-${spout.cluster}-${spout.source}"; Review comment: can we make the new vars more consistent? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
