lpan commented on a change in pull request #3330: [STREAMCOMP-2885] broadcast
GCC completition
URL: https://github.com/apache/incubator-heron/pull/3330#discussion_r320954937
##########
File path:
heron/instance/src/java/org/apache/heron/instance/spout/SpoutInstance.java
##########
@@ -296,9 +299,6 @@ public void run() {
spoutMetrics.updateOutQueueFullCount();
}
- // Check if we have any message to process anyway
- readTuplesAndExecute(streamInQueue);
-
Review comment:
I made a small change to the message processing order for `SpoutInstance`.
Before, when the spout task is waken up by the event loop, it will attempt
to emit tuples first. And then, it will process the control messages. Now it
will process the control tuples first and then try to emit the tuples. Note
that this change will only impact stateful topology (spout instances in
non-stateful topology will not receive any control messages)
Implementing blocking emitting tuples until checkpoint is completed requires
to process control messages first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
