lpan commented on a change in pull request #3330: [STREAMCOMP-2885] broadcast
GCC completition
URL: https://github.com/apache/incubator-heron/pull/3330#discussion_r321456131
##########
File path:
heron/instance/src/java/org/apache/heron/instance/spout/SpoutInstance.java
##########
@@ -296,9 +299,6 @@ public void run() {
spoutMetrics.updateOutQueueFullCount();
}
- // Check if we have any message to process anyway
- readTuplesAndExecute(streamInQueue);
-
Review comment:
`readTuplesAndExecute` in `SpoutInstance` only reads control tuples, and we
don't need to block them. For spouts we only want to block `nextTuple` and for
bolts we want to block `execute` (which takes place in the
`readTuplesAndExecute` method).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
