nlu90 commented on a change in pull request #3330: [STREAMCOMP-2885] broadcast
GCC completition
URL: https://github.com/apache/incubator-heron/pull/3330#discussion_r321404341
##########
File path: heron/instance/src/java/org/apache/heron/instance/IInstance.java
##########
@@ -57,6 +57,21 @@
*/
void clean();
+ /**
+ * Inform the Instance that the framework will clean, stop, and delete the
instance
+ * in order to restore its state to a previously-saved checkpoint.
+ *
+ * @param checkpointId the ID of the checkpoint the instance will be
restoring to
+ */
+ void preRestore(String checkpointId);
+
+ /**
+ * Inform the Instance that a particular checkpoint has become globally
consistent
+ *
+ * @param checkpointId the ID of the checkpoint that became globally
consistent
+ */
+ void onCheckpointSaved(String checkpointId);
Review comment:
These two new interfaces are stateful topology specific. Instead of adding
them here in the general `IInstance`, could we find a cleaner way to put them
somewhere else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
