nlu90 commented on a change in pull request #3330: [STREAMCOMP-2885] broadcast
GCC completition
URL: https://github.com/apache/incubator-heron/pull/3330#discussion_r321418118
##########
File path:
heron/instance/src/java/org/apache/heron/instance/spout/SpoutInstance.java
##########
@@ -296,9 +299,6 @@ public void run() {
spoutMetrics.updateOutQueueFullCount();
}
- // Check if we have any message to process anyway
- readTuplesAndExecute(streamInQueue);
-
Review comment:
This change should be fine.
But I think you will need to update the `realTuplesAndExecute` method in the
SpoutInstance to actually implement the blocking mechanism, just like what you
did for the `BoltInstance`. Currently, the blocking is implemented in the
`isProduceTuple` method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
