nwangtw commented on a change in pull request #3330: [STREAMCOMP-2885]
broadcast GCC completition
URL: https://github.com/apache/incubator-heron/pull/3330#discussion_r321460660
##########
File path:
heron/instance/src/java/org/apache/heron/instance/spout/SpoutInstance.java
##########
@@ -296,9 +299,6 @@ public void run() {
spoutMetrics.updateOutQueueFullCount();
}
- // Check if we have any message to process anyway
- readTuplesAndExecute(streamInQueue);
-
Review comment:
The ordering change sounds ok to me.
One concern is the barrier though. I think each stream needs a separated
blocker. I just want to confirm that this is included in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
