xiaoyao1991 commented on a change in pull request #3350: Clean up rate limit
config and add an example topology
URL: https://github.com/apache/incubator-heron/pull/3350#discussion_r329748622
##########
File path: heron/api/src/java/org/apache/heron/api/Config.java
##########
@@ -1029,8 +1029,4 @@ public void setTopologyRemoteDebugging(boolean isOn) {
public void setTopologyDropTuplesUponBackpressure(boolean dropTuples) {
this.put(Config.TOPOLOGY_DROPTUPLES_UPON_BACKPRESSURE,
String.valueOf(dropTuples));
}
-
- public void setTopologyComponentOutputBPS(long bps) {
- this.put(Config.TOPOLOGY_COMPONENT_OUTPUT_BPS, String.valueOf(bps));
- }
Review comment:
Would the removal of these 2 methods break some existing topologies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
