nwangtw commented on a change in pull request #3350: Clean up rate limit config
and add an example topology
URL: https://github.com/apache/incubator-heron/pull/3350#discussion_r329764481
##########
File path: heron/api/src/java/org/apache/heron/api/Config.java
##########
@@ -1029,8 +1029,4 @@ public void setTopologyRemoteDebugging(boolean isOn) {
public void setTopologyDropTuplesUponBackpressure(boolean dropTuples) {
this.put(Config.TOPOLOGY_DROPTUPLES_UPON_BACKPRESSURE,
String.valueOf(dropTuples));
}
-
- public void setTopologyComponentOutputBPS(long bps) {
- this.put(Config.TOPOLOGY_COMPONENT_OUTPUT_BPS, String.valueOf(bps));
- }
Review comment:
Shouldn't be. These two functions were added by mistake.
I double-checked the source code in topology-config-helper.cpp and it is
supported to be used as component config only.
The concern is valid though. Do you feel it is safer to annotate with
@Deprecated? Or is there a better annotation for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
