xiaoyao1991 commented on a change in pull request #3359: Hook up a packing plan
endpoint in Heron UI
URL: https://github.com/apache/incubator-heron/pull/3359#discussion_r332151916
##########
File path: heron/tools/tracker/src/python/tracker.py
##########
@@ -660,6 +665,10 @@ def setTopologyInfo(self, topology):
topologyInfo["logical_plan"] = self.extract_logical_plan(topology)
topologyInfo["physical_plan"] = self.extract_physical_plan(topology)
topologyInfo["packing_plan"] = self.extract_packing_plan(topology)
+ # extract_packing_plan() was the original implementation. The result is
dumped
Review comment:
I'm thinking that we should probably eliminate the old implementation. I've
seen this when implementing my dashboard. Long plain string of a json is not
useful in any case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
