xiaoyao1991 commented on a change in pull request #3359: Hook up a packing plan endpoint in Heron UI URL: https://github.com/apache/incubator-heron/pull/3359#discussion_r332150654
########## File path: heron/tools/common/src/python/access/heron_api.py ########## @@ -35,6 +35,7 @@ EXECUTION_STATE_URL_FMT = "%s/executionstate" % TOPOLOGIES_URL_FMT LOGICALPLAN_URL_FMT = "%s/logicalplan" % TOPOLOGIES_URL_FMT PHYSICALPLAN_URL_FMT = "%s/physicalplan" % TOPOLOGIES_URL_FMT +PACKINGPLAN_URL_FMT = "%s/packingplanjson" % TOPOLOGIES_URL_FMT Review comment: can we leave out the `json` suffix? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
