nwangtw commented on a change in pull request #3359: Hook up a packing plan
endpoint in Heron UI
URL: https://github.com/apache/incubator-heron/pull/3359#discussion_r332153831
##########
File path: heron/tools/tracker/src/python/tracker.py
##########
@@ -660,6 +665,10 @@ def setTopologyInfo(self, topology):
topologyInfo["logical_plan"] = self.extract_logical_plan(topology)
topologyInfo["physical_plan"] = self.extract_physical_plan(topology)
topologyInfo["packing_plan"] = self.extract_packing_plan(topology)
+ # extract_packing_plan() was the original implementation. The result is
dumped
Review comment:
Yeah. That is true. I am keeping the old one to be safe just in case it is
used anywhere or by anyone. If it is safe enough then I am happy to just
replace the old implementation. It is not consistent with the others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
