nwangtw commented on a change in pull request #3444: Fixing setup script: Do
Not Merge
URL: https://github.com/apache/incubator-heron/pull/3444#discussion_r374791835
##########
File path: scripts/get_all_heron_paths.sh
##########
@@ -112,7 +112,7 @@ function collect_generated_paths() {
# uniq to avoid doing blaze query on duplicates.
for path in $(find bazel-genfiles/ -name "*.java" | sed
's|/\{0,1\}bazel-genfiles/\{1,2\}|//|' | uniq); do
source_path=$(echo ${path} | sed 's|//|bazel-genfiles/|' | sed
's|/com/.*$||')
- echo "$(get_containing_library ${path}):${source_path}"
+# echo "$(get_containing_library ${path}):${source_path}"
Review comment:
It looks like this is the output of the for loop, which calls the removed
functions. I don't really know this part of the code base but it might be
useful I feel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
