joshfischer1108 opened a new pull request #3444: Fixing setup script: Do Not 
Merge
URL: https://github.com/apache/incubator-heron/pull/3444
 
 
   This is my attempt to fix the IDE setup script.  I commented out some code 
that was breaking the initialization script when starting both intellij and 
eclipse.   I can understand what the code is doing, but I'm not sure why it is 
needed for loading Heron into an IDE. I'll as of now I can run the script, it 
compiles Heron and opens up Intellij for me without errors.   I'm double 
checking and asking for feedback to make sure I didn't comment out any needed 
code.  Please review. 
   Below is my output on a mac.
   
   I check that the iml file exists, delete the `.iml` file from the folder, 
run the script and check that the `.iml` file has been created again.   The IDE 
also opens up for me and seems to be working as expected.
   
   ```
   Joshs-MacBook-Pro-2:incubator-heron joshfischer$ ls | grep heron.iml
   heron.iml
   Joshs-MacBook-Pro-2:incubator-heron joshfischer$ rm heron.iml 
   Joshs-MacBook-Pro-2:incubator-heron joshfischer$ ./scripts/setup-intellij.sh 
   changing to /Users/joshfischer/Source/apache/incubator-heron/scripts/..
   WARNING: 
/Users/joshfischer/Source/apache/incubator-heron/heron/healthmgr/tests/java/BUILD:52:12:
 in srcs attribute of java_library rule 
//heron/healthmgr/tests/java:healthmgr-tests: please do not import 
'//heron/healthmgr/src/java:org/apache/heron/healthmgr/HealthManager.java' 
directly. You should either move the file to this package or depend on an 
appropriate rule there
   INFO: Analyzed 759 targets (0 packages loaded, 0 targets configured).
   INFO: Found 759 targets...
   INFO: Elapsed time: 0.465s, Critical Path: 0.06s
   INFO: 0 processes.
   INFO: Build completed successfully, 1 total action
   Bazel build successful!!
   Path is /Users/joshfischer/Source/apache/incubator-heron
   Generating IDEA project...
   Loading: 0 packages loaded
   Done. IDEA module file: heron.iml
   Opening Heron project in IDEA...
   Done.
   Joshs-MacBook-Pro-2:incubator-heron joshfischer$ ls | grep heron.iml
   heron.iml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to