jiacai2050 commented on code in PR #1533:
URL:
https://github.com/apache/incubator-horaedb/pull/1533#discussion_r1611584541
##########
src/analytic_engine/src/table/data.rs:
##########
@@ -329,7 +329,7 @@ impl TableData {
.mutable_segment_switch_threshold
.0 as usize;
let enable_layered_memtable = mutable_segment_switch_threshold > 0;
- let memtable_factory = if enable_layered_memtable {
+ let memtable_factory = if enable_layered_memtable &&
!opts.need_dedup() {
Review Comment:
The fix is not suitable here, we should check table options when create
table, and throw error when enable layered memtable for OVERWRITE table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
