Rachelint commented on code in PR #1533:
URL:
https://github.com/apache/incubator-horaedb/pull/1533#discussion_r1613098102
##########
src/analytic_engine/src/table/data.rs:
##########
@@ -329,7 +329,7 @@ impl TableData {
.mutable_segment_switch_threshold
.0 as usize;
let enable_layered_memtable = mutable_segment_switch_threshold > 0;
- let memtable_factory = if enable_layered_memtable {
+ let memtable_factory = if enable_layered_memtable &&
!opts.need_dedup() {
Review Comment:
I move the check before table creation/alter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
