jiacai2050 commented on code in PR #1539:
URL: https://github.com/apache/horaedb/pull/1539#discussion_r1706458670
##########
src/remote_engine_client/src/client.rs:
##########
@@ -140,33 +144,35 @@ impl Client {
// Write to remote.
let table_ident = request.table.clone();
let endpoint = route_context.endpoint.clone();
- let request_pb = request.convert_into_pb().box_err().context(Convert {
- msg: "Failed to convert WriteRequest to pb",
+ let request_fb = request.convert_into_fb().box_err().context(Convert {
+ msg: "Failed to convert WriteRequest to fb",
})?;
- let mut rpc_client =
RemoteEngineServiceClient::<Channel>::new(route_context.channel);
+
+ let mut rpc_client =
RemoteEngineFbServiceClient::<Channel>::new(route_context.channel);
Review Comment:
Does this mean remote server will only have request with fb payload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
