jiacai2050 commented on PR #1539:
URL: https://github.com/apache/horaedb/pull/1539#issuecomment-2297859926
As said in description, the improvement after introduce Flatbuffer is not
what we originally expected, the reason is that this PR only refactor upper
layer of the put request, the `ContiguousRow`'s encoding is unchanged, however
it's where cost mainly come from, so we cannot get much perf improvement
without refactor it.
But ContiguousRow is a heavily used structure in write path, refactor it
would introduce much more changes, so I suggest we stop working on this, sorry
for not find this earlier.
Really appreciated your work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
