vinothchandar commented on a change in pull request #600: Timeline Service
with Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271990580
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/table/HoodieCopyOnWriteTable.java
##########
@@ -231,7 +230,7 @@ protected HoodieMergeHandle getUpdateHandle(String
commitTime, String fileId,
}
protected HoodieMergeHandle getUpdateHandle(String commitTime, String fileId,
- Map<String, HoodieRecord<T>> keyToNewRecords, Optional<HoodieDataFile>
dataFileToBeMerged) {
+ Map<String, HoodieRecord<T>> keyToNewRecords, HoodieDataFile
dataFileToBeMerged) {
Review comment:
Around assuming there is always a base file for updates. How would small
insert handling in MOR work? Do we always write a parquet file if one does not
exist in a ingest batch today? I don't know if that's the model we want to
emulate in future though.. Should we able to first write data onto logs even
without parquet files and later batch compact them together ? otherwise, this
will block streaming ingest rght
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services