vinothchandar commented on a change in pull request #600:  Timeline Service 
with Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271951606
 
 

 ##########
 File path: 
hoodie-client/src/main/java/com/uber/hoodie/CompactionAdminClient.java
 ##########
 @@ -123,19 +120,17 @@ public CompactionAdminClient(JavaSparkContext jsc, 
String basePath) {
     // Only if all operations are successfully executed
     if (!dryRun && allSuccess.isPresent() && allSuccess.get()) {
       // Overwrite compaction request with empty compaction operations
-      HoodieCompactionPlan plan = 
CompactionUtils.getCompactionPlan(metaClient, compactionInstant);
-      HoodieCompactionPlan newPlan =
-          HoodieCompactionPlan.newBuilder().setOperations(new 
ArrayList<>()).setExtraMetadata(plan.getExtraMetadata())
-              .build();
       HoodieInstant inflight = new HoodieInstant(State.INFLIGHT, 
COMPACTION_ACTION, compactionInstant);
       Path inflightPath = new Path(metaClient.getMetaPath(), 
inflight.getFileName());
       if (metaClient.getFs().exists(inflightPath)) {
         // We need to rollback data-files because of this inflight compaction 
before unscheduling
         throw new IllegalStateException("Please rollback the inflight 
compaction before unscheduling");
       }
-      metaClient.getActiveTimeline().saveToCompactionRequested(
-          new HoodieInstant(State.REQUESTED, COMPACTION_ACTION, 
compactionInstant),
-          AvroUtils.serializeCompactionPlan(newPlan));
+      // Leave the trace in aux folder but delete from metapath.
+      // TODO: Add a rollback instant but for compaction
 
 Review comment:
   why are these changes needed as a part of timeline service? should this go 
in its own pR? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to