bvaradar commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276451108
########## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/view/SpillableMapBasedFileSystemView.java ########## @@ -0,0 +1,95 @@ +/* + * Copyright (c) 2018 Uber Technologies, Inc. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.uber.hoodie.common.table.view; + +import com.uber.hoodie.common.model.CompactionOperation; +import com.uber.hoodie.common.model.HoodieFileGroup; +import com.uber.hoodie.common.model.HoodieFileGroupId; +import com.uber.hoodie.common.table.HoodieTableMetaClient; +import com.uber.hoodie.common.table.HoodieTimeline; +import com.uber.hoodie.common.util.DefaultSizeEstimator; +import com.uber.hoodie.common.util.collection.ExternalSpillableMap; +import com.uber.hoodie.common.util.collection.Pair; +import java.io.File; +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.stream.Stream; +import org.apache.hadoop.fs.FileStatus; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +/** + * Table FileSystemView implementation where view is stored in spillable disk using fixed memory + */ +public class SpillableMapBasedFileSystemView extends HoodieTableFileSystemView { + + private static Logger log = LogManager.getLogger(SpillableMapBasedFileSystemView.class); + + private final long maxMemoryForFileGroupMap; + private final long maxMemoryForPendingCompaction; + private final String baseStoreDir; + + public SpillableMapBasedFileSystemView(HoodieTableMetaClient metaClient, + HoodieTimeline visibleActiveTimeline, FileSystemViewStorageConfig config) { + this.maxMemoryForFileGroupMap = config.getMaxMemoryForFileGroupMap(); + this.maxMemoryForPendingCompaction = config.getMaxMemoryForPendingCompaction(); Review comment: In the case of SpillableMapFIleSystemView, both the file-system view map and the map storing pending compactions uses spillableMap. This config is to control memory allocation for that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
