bvaradar commented on a change in pull request #600: Timeline Service with
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276887431
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/table/TableFileSystemView.java
##########
@@ -30,55 +31,68 @@
public interface TableFileSystemView {
/**
- * ReadOptimizedView - methods to provide a view of columnar data files only.
+ * ReadOptimizedView with methods to only access latest version of file for
the instant(s) passed.
*/
- interface ReadOptimizedView {
+ interface ReadOptimizedViewWithLatestSlice {
/**
* Stream all the latest data files in the given partition
*/
Stream<HoodieDataFile> getLatestDataFiles(String partitionPath);
+ /**
+ * Get Latest data file for a partition and file-Id
+ */
+ Option<HoodieDataFile> getLatestDataFile(String partitionPath, String
fileId);
+
/**
* Stream all the latest data files, in the file system view
*/
Stream<HoodieDataFile> getLatestDataFiles();
/**
- * Stream all the latest version data files in the given partition with
precondition that
- * commitTime(file) before maxCommitTime
+ * Stream all the latest version data files in the given partition with
precondition that commitTime(file) before
+ * maxCommitTime
*/
Stream<HoodieDataFile> getLatestDataFilesBeforeOrOn(String partitionPath,
String maxCommitTime);
/**
- * Stream all the latest version data files in the given partition with
precondition that
- * instant time of file matches passed in instant time.
+ * Get the version of data file matching the instant time in the given
partition
*/
- Stream<HoodieDataFile> getLatestDataFilesOn(String partitionPath, String
instantTime);
+ Option<HoodieDataFile> getLatestDataFileOn(String partitionPath, String
instantTime, String fileId);
Review comment:
Renamed it getDataFileOn and moved it from ReadOptimizedViewWithLatestSlice
to ReadOptimizedView
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
