vinothchandar commented on a change in pull request #657: [HUDI-57] support orc file URL: https://github.com/apache/incubator-hudi/pull/657#discussion_r280094632
########## File path: hoodie-hadoop-mr/src/main/java/com/uber/hoodie/hadoop/realtime/HoodieOrcRealtimeInputFormat.java ########## @@ -0,0 +1,92 @@ +/* + * Copyright (c) 2016 Uber Technologies, Inc. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.uber.hoodie.hadoop.realtime; + +import com.uber.hoodie.common.model.HoodieRecord; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.apache.hadoop.conf.Configurable; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.ql.io.orc.OrcInputFormat; +import org.apache.hadoop.hive.serde2.ColumnProjectionUtils; + +/** + * ORC Input Format, that provides a real-time view of data in a Hoodie dataset + */ +public class HoodieOrcRealtimeInputFormat extends OrcInputFormat implements Configurable { Review comment: can we create two input formats like we do for Parquet.. HoodieOrcInputFormat and HoodieOrcRealtimeInputFormat to match HoodieInputFormat and HoodieRealtimeInputFormat? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
