vinothchandar commented on a change in pull request #657: [HUDI-57] support orc file URL: https://github.com/apache/incubator-hudi/pull/657#discussion_r279969173
########## File path: hoodie-client/src/main/java/com/uber/hoodie/config/HoodieWriteConfig.java ########## @@ -72,6 +73,9 @@ private static final String CONSISTENCY_CHECK_ENABLED = "hoodie.consistency.check.enabled"; private static final String DEFAULT_CONSISTENCY_CHECK_ENABLED = "false"; + private static final String FILE_TYPE = "hoodie.file.type"; Review comment: rename to "hoodie.data.file.format" ? to be consistent with how we refer to this? Also worth adding an entry to `HoodieFileFormat` class and turn this value into a setting of that enum.. ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
