bvaradar commented on a change in pull request #775: HUDI-162 : File System 
view must be built with correct timeline actions
URL: https://github.com/apache/incubator-hudi/pull/775#discussion_r303228201
 
 

 ##########
 File path: 
hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java
 ##########
 @@ -92,20 +92,29 @@ private String getPartitionPathFromFilePath(String 
fullPath) {
    */
   protected void init(HoodieTableMetaClient metaClient, HoodieTimeline 
visibleActiveTimeline) {
     this.metaClient = metaClient;
-    this.visibleActiveTimeline = visibleActiveTimeline;
+    updateTimeline(visibleActiveTimeline);
+
     // Load Pending Compaction Operations
     resetPendingCompactionOperations(
         CompactionUtils.getAllPendingCompactionOperations(metaClient).values()
             .stream().map(e -> Pair.of(e.getKey(),
             CompactionOperation.convertFromAvroRecordInstance(e.getValue()))));
   }
 
+  /**
+   * Update commits timeline
+   * @param visibleActiveTimeline  Visible Active Timeline
+   */
+  protected void updateTimeline(HoodieTimeline visibleActiveTimeline) {
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to