bvaradar commented on a change in pull request #775: HUDI-162 : File System
view must be built with correct timeline actions
URL: https://github.com/apache/incubator-hudi/pull/775#discussion_r303228222
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java
##########
@@ -822,10 +832,18 @@ public void sync() {
* @param newTimeline New Hoodie Timeline
*/
protected void runSync(HoodieTimeline oldTimeline, HoodieTimeline
newTimeline) {
- visibleActiveTimeline = newTimeline;
+ updateTimeline(newTimeline);
addedPartitions.clear();
resetViewState();
// Initialize with new Hoodie timeline.
init(metaClient, newTimeline);
}
+
+ /**
+ * Return Only Commits and Compaction timeline for building file-groups
+ * @return
+ */
+ public HoodieTimeline getVisibleCommitsAndCompactionTimeline() {
Review comment:
This is needed to distinguish active timeline from
commitsAndCompactionTimeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
