n3nash commented on a change in pull request #795: HUDI-171 delete tmp file
after split merge failure
URL: https://github.com/apache/incubator-hudi/pull/795#discussion_r307021873
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/util/collection/DiskBasedMap.java
##########
@@ -106,7 +106,16 @@ private void initFile(File writeOnlyFileHandle) throws
IOException {
if (!writeOnlyFileHandle.getParentFile().exists()) {
writeOnlyFileHandle.getParentFile().mkdir();
}
- writeOnlyFileHandle.createNewFile();
+ // create the file
+ try {
+ writeOnlyFileHandle.createNewFile();
Review comment:
@vinothchandar The delteOnExit() code is already present, that's how we
clean up all files here. In this case, what @garyli1019 is seeing is that the
job fails right after creation before the deleteOnExit(). Either the
deleteOnExit is moved to finally or we register shutdown with the exception
when sigkill -9 is invoked there may be files lying around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
