n3nash commented on a change in pull request #795: HUDI-171 delete tmp file
after split merge failure
URL: https://github.com/apache/incubator-hudi/pull/795#discussion_r310400964
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/util/collection/DiskBasedMap.java
##########
@@ -140,7 +142,8 @@ public void run() {
}
}
} catch (Exception e) {
- // fail silently for any sort of exception
+ // delete the file for any sort of exception
+ writeOnlyFile.delete();
Review comment:
This is good, please add writeOnlyFile.delete() inside addShutDownHook()
method as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
