yanghua commented on a change in pull request #826: [HUDI-153] Use
com.uber.hoodie.common.util.Option instead of Java and Guava Optional
URL: https://github.com/apache/incubator-hudi/pull/826#discussion_r311511072
##########
File path: hoodie-hive/src/main/java/com/uber/hoodie/hive/HoodieHiveClient.java
##########
@@ -556,7 +556,7 @@ public void close() {
}
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
- List<String> getPartitionsWrittenToSince(Optional<String>
lastCommitTimeSynced) {
+ List<String> getPartitionsWrittenToSince(Option<String>
lastCommitTimeSynced) {
Review comment:
I think we should keep it there because we still use `Option`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
