yanghua commented on a change in pull request #826: [HUDI-153] Use
com.uber.hoodie.common.util.Option instead of Java and Guava Optional
URL: https://github.com/apache/incubator-hudi/pull/826#discussion_r311517237
##########
File path: hoodie-client/src/main/java/com/uber/hoodie/WriteStatus.java
##########
@@ -73,7 +73,7 @@ public WriteStatus(Boolean trackSuccessRecords, Double
failureFraction) {
* @param optionalRecordMetadata optional metadata related to data contained
in {@link
* HoodieRecord} before deflation.
*/
- public void markSuccess(HoodieRecord record, Optional<Map<String, String>>
optionalRecordMetadata) {
+ public void markSuccess(HoodieRecord record, Option<Map<String, String>>
optionalRecordMetadata) {
Review comment:
Conventionally, ensuring API compatibility is a critical consideration.
However, I don't think we need to worry too much at the moment. Hudi has
just joined Apache and has not had a heavy historical burden. Since we decided
to replace it, we should be firm. After that, we can add java.util.Optional and
guava's Option as rules to the check style plugin, prohibiting users from using
them. In a subsequent version, we can claim to ensure backward compatibility.
When Hudi's API is basically stable, we can mark the stability level of the
API with some annotations such as `@Public`, `@PublicEvolving`, and then use
tools to check their compatibility. (As far as I know, Flink tried this
mechanism).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
