bvaradar commented on a change in pull request #863: [HUDI-227] : DeltaStreamer
Improvements : Commit empty input batch with progressing checkpoints and allow
users to override configs through properties
URL: https://github.com/apache/incubator-hudi/pull/863#discussion_r319355998
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java
##########
@@ -81,6 +84,7 @@
* upserts, inserts. Check counts at the end.
*/
public class TestHoodieDeltaStreamer extends UtilitiesTestBase {
+
private static final String PROPS_FILENAME_TEST_SOURCE =
"test-source.properties";
private static final String PROPS_FILENAME_TEST_INVALID =
"test-invalid.properties";
private static volatile Logger log =
LogManager.getLogger(TestHoodieDeltaStreamer.class);
Review comment:
@leesf : Thanks for your suggestion. We are not following this convention
w.r.t test-classes. If you have references to published conventions that we are
missing, happy to hear about them :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
