bvaradar commented on a change in pull request #863: [HUDI-227] : DeltaStreamer
Improvements : Commit empty input batch with progressing checkpoints and allow
users to override configs through properties
URL: https://github.com/apache/incubator-hudi/pull/863#discussion_r319356000
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -299,11 +302,17 @@ private void refreshTimeline() throws IOException {
schemaProvider = dataAndCheckpoint.getSchemaProvider();
}
- if ((!avroRDDOptional.isPresent()) || (avroRDDOptional.get().isEmpty())) {
- log.info("No new data, nothing to commit.. ");
+ if (Objects.equals(checkpointStr, resumeCheckpointStr.orElse(null))) {
+ log.info("No new data, source checkpoint has not changed. Nothing to
commit."
+ + "Old checkpoint=(" + resumeCheckpointStr + "). New Checkpoint=(" +
checkpointStr + ")");
Review comment:
@leesf log.info (at-least the version we use) itself does not support
variable args. It has to be log.info(String.format(xxxx)). Looks verbose IMO :)
We are using the current style everywhere in the code. So, inclined to leave
it like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
