vinothchandar commented on a change in pull request #876: [HUDI-62] Index
Lookup Timer added to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/876#discussion_r321972066
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -468,8 +476,12 @@ private Partitioner getPartitioner(HoodieTable table,
boolean isUpsert, Workload
// cache writeStatusRDD before updating index, so that all actions before
this are not triggered again for future
// RDD actions that are performed after updating the index.
writeStatusRDD =
writeStatusRDD.persist(config.getWriteStatusStorageLevel());
+ indexLookupTimer = metrics.getIndexLookupCtx();
// Update the index back
JavaRDD<WriteStatus> statuses = index.updateLocation(writeStatusRDD, jsc,
table);
+ metrics.updateIndexLookupMetrics(metrics.getDurationInMs(indexLookupTimer
== null ? 0L :
Review comment:
we should report this a separate indexUpdate metric, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
