vinothchandar commented on a change in pull request #876: [HUDI-62] Index 
Lookup Timer added to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/876#discussion_r324761029
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java
 ##########
 @@ -172,6 +182,15 @@ public void updateFinalizeWriteMetrics(long durationInMs, 
long numFilesFinalized
     }
   }
 
+  public void updateIndexMetrics(final String action,final long durationInMs) {
 
 Review comment:
   nit: single space after comma and next argument?  `action, final long` ? (I 
am surprised checkstyle does not have this. hmm.. @bvaradar ) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to