leesf commented on a change in pull request #940: [HUDI-130] Paths written in
compaction plan needs to be relative to base-path
URL: https://github.com/apache/incubator-hudi/pull/940#discussion_r331748140
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -1249,13 +1250,13 @@ private HoodieTable
getTableAndInitCtx(JavaRDD<HoodieRecord<T>> records) {
*/
private JavaRDD<WriteStatus> runCompaction(
HoodieInstant compactionInstant, HoodieActiveTimeline activeTimeline,
boolean autoCommit) throws IOException {
- HoodieCompactionPlan compactionPlan = AvroUtils.deserializeCompactionPlan(
- activeTimeline.getInstantAuxiliaryDetails(compactionInstant).get());
+ HoodieTableMetaClient metaClient = createMetaClient(true);
+ HoodieCompactionPlan compactionPlan =
CompactionUtils.getCompactionPlan(metaClient,
+ compactionInstant.getTimestamp());
// Mark instant as compaction inflight
activeTimeline.transitionCompactionRequestedToInflight(compactionInstant);
compactionTimer = metrics.getCompactionCtx();
// Create a Hoodie table which encapsulated the commits and files visible
Review comment:
Would move this comment before the createMetaClient(true).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services