leesf commented on a change in pull request #940: [HUDI-130] Paths written in compaction plan needs to be relative to base-path URL: https://github.com/apache/incubator-hudi/pull/940#discussion_r331779210
########## File path: hudi-common/src/main/java/org/apache/hudi/common/model/version/compaction/CompactionV1MigrationHandler.java ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.model.version.compaction; + +import com.google.common.base.Preconditions; +import java.util.List; +import java.util.stream.Collectors; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.avro.model.HoodieCompactionOperation; +import org.apache.hudi.avro.model.HoodieCompactionPlan; +import org.apache.hudi.common.model.version.AbstractMigratorBase; +import org.apache.hudi.common.table.HoodieTableMetaClient; + +/** + * Compaction V1 has absolute paths as part of compaction operations + */ +public class CompactionV1MigrationHandler extends AbstractMigratorBase<HoodieCompactionPlan> { + + public CompactionV1MigrationHandler(HoodieTableMetaClient metaClient) { + super(metaClient); + } + + @Override + public Integer getManagedVersion() { + return 1; Review comment: How about change 1 to CompactionUtils.COMPACTION_METADATA_VERSION_1 to avoid magic number? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
