n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)
URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r341913553
##########
File path:
hudi-bench/src/main/java/org/apache/hudi/bench/dag/nodes/DagNode.java
##########
@@ -0,0 +1,104 @@
+package org.apache.hudi.bench.dag.nodes;
+
+import java.util.ArrayList;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Objects;
+import java.util.UUID;
+import org.apache.hudi.bench.configuration.DeltaConfig.Config;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+/**
+ * Represents a Node in the DAG of operations for a workflow.
+ */
+public abstract class DagNode<O> implements Comparable<DagNode<O>> {
Review comment:
The idea was to have the execute method return it's output so we can
actually perform validations at any level in the DAG if needed.
If you take a look at ValidateNode, that's what it does, but it just uses
the output of the last execution which is stored as a result (which is another
option and make the execute void type). Let me think about this a little more.
I like the idea about removing the if-else and have an abstract method, just
want to see if we can generalize it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
