n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360659
########## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/nodes/HiveSyncNode.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.bench.dag.nodes; + +import org.apache.hudi.bench.configuration.DeltaConfig.Config; +import org.apache.hudi.bench.dag.ExecutionContext; +import org.apache.hudi.bench.helpers.HiveServerWrapper; + +public class HiveSyncNode extends DagNode<Boolean> { + + private HiveServerWrapper hiveServerWrapper; + + public HiveSyncNode(Config config) { + this.config = config; + this.hiveServerWrapper = new HiveServerWrapper(config); + } + + @Override + public void execute(ExecutionContext executionContext) throws Exception { + log.info("Executing hive sync node..."); + this.hiveServerWrapper.startLocalHiveServiceIfNeeded(executionContext.getDeltaWriter().getConfiguration()); + this.hiveServerWrapper.syncToLocalHiveIfNeeded(executionContext.getDeltaWriter()); Review comment: If I leave the local hive service long running, ran into issues such as permissions when the second time a hive query needs to be executed. Ideally, we should have it long running but requires more debugging in Hive to make it work, hence chose to just restart. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
