yanghua commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344619724
########## File path: hudi-bench/src/main/java/org/apache/hudi/bench/job/HoodieTestSuiteJob.java ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.bench.job; + +import com.beust.jcommander.JCommander; +import com.beust.jcommander.Parameter; +import java.io.IOException; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hudi.DataSourceUtils; +import org.apache.hudi.KeyGenerator; +import org.apache.hudi.bench.DeltaInputFormat; +import org.apache.hudi.bench.DeltaOutputType; +import org.apache.hudi.bench.configuration.DFSDeltaConfig; +import org.apache.hudi.bench.dag.DagUtils; +import org.apache.hudi.bench.dag.WorkflowDag; +import org.apache.hudi.bench.dag.WorkflowDagGenerator; +import org.apache.hudi.bench.dag.scheduler.DagScheduler; +import org.apache.hudi.bench.generator.DeltaGenerator; +import org.apache.hudi.bench.writer.DeltaWriter; +import org.apache.hudi.common.SerializableConfiguration; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.util.FSUtils; +import org.apache.hudi.common.util.ReflectionUtils; +import org.apache.hudi.common.util.TypedProperties; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.utilities.UtilHelpers; +import org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer; +import org.apache.hudi.utilities.schema.SchemaProvider; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; +import org.apache.spark.api.java.JavaSparkContext; +import org.apache.spark.sql.SparkSession; + +/** + * This is the entry point for running a Hudi Test Suite. Although this class has similarities with + * {@link HoodieDeltaStreamer} this class does not extend it since do not want to create a dependency on the changes in + * DeltaStreamer. + */ +public class HoodieTestSuiteJob { + + private static volatile Logger log = LogManager.getLogger(HoodieTestSuiteJob.class); + + private final HoodieTestSuiteConfig cfg; + /** + * Bag of properties with source, hoodie client, key generator etc. + */ + TypedProperties props; + /** + * Schema provider that supplies the command for writing out the generated payloads + */ + private transient SchemaProvider schemaProvider; Review comment: It would be better to insert an empty line after each field? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
