yanghua commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344612399
########## File path: hudi-bench/src/main/java/org/apache/hudi/bench/writer/AvroDeltaInputWriter.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.bench.writer; + +import java.io.IOException; +import java.io.OutputStream; +import java.util.UUID; +import org.apache.avro.Schema; +import org.apache.avro.file.DataFileWriter; +import org.apache.avro.generic.GenericDatumWriter; +import org.apache.avro.generic.GenericRecord; +import org.apache.avro.generic.IndexedRecord; +import org.apache.avro.io.DatumWriter; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.common.io.storage.HoodieWrapperFileSystem; +import org.apache.hudi.io.storage.HoodieParquetWriter; +import org.apache.log4j.Logger; + +/** + * Implementation of {@link FileDeltaInputWriter} that writes avro records to the result file + */ +public class AvroDeltaInputWriter implements FileDeltaInputWriter<GenericRecord> { + + public static final String AVRO_EXTENSION = ".avro"; + private static Logger log = Logger.getLogger(AvroDeltaInputWriter.class); Review comment: Generally speaking, we'd better let the logger definition statement as the first statement and split it with another definition by using an empty line. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
