vinothchandar commented on a change in pull request #1009: [HUDI-308] Avoid
Renames for tracking state transitions of all actions on dataset
URL: https://github.com/apache/incubator-hudi/pull/1009#discussion_r348081815
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTimeline.java
##########
@@ -250,7 +253,10 @@ static HoodieInstant getCompactionInflightInstant(final
String timestamp) {
return new HoodieInstant(State.INFLIGHT, COMPACTION_ACTION, timestamp);
}
- static HoodieInstant getInflightInstant(final HoodieInstant instant) {
+ static HoodieInstant getInflightInstant(final HoodieInstant instant, final
HoodieTableType tableType) {
+ if ((tableType == HoodieTableType.MERGE_ON_READ) &&
instant.getAction().equals(COMMIT_ACTION)) {
Review comment:
add some comments for this special handling? I 'd prefer keeping this here
compared to pushing this to HoodieInstant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
