vinothchandar commented on a change in pull request #1009: [HUDI-308] Avoid
Renames for tracking state transitions of all actions on dataset
URL: https://github.com/apache/incubator-hudi/pull/1009#discussion_r348083993
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -212,25 +224,24 @@ public void saveAsComplete(HoodieInstant instant,
Option<byte[]> data) {
log.info("Completed " + instant);
}
- public void revertToInflight(HoodieInstant instant) {
- log.info("Reverting " + instant + " to inflight ");
- revertStateTransition(instant, HoodieTimeline.getInflightInstant(instant));
- log.info("Reverted " + instant + " to inflight");
- }
-
- public HoodieInstant revertToRequested(HoodieInstant instant) {
- log.warn("Reverting " + instant + " to requested ");
- HoodieInstant requestedInstant =
HoodieTimeline.getRequestedInstant(instant);
- revertStateTransition(instant,
HoodieTimeline.getRequestedInstant(instant));
- log.warn("Reverted " + instant + " to requested");
- return requestedInstant;
+ public HoodieInstant revertToInflight(HoodieInstant instant) {
+ log.info("Reverting instant to inflight " + instant);
+ HoodieInstant inflight = HoodieTimeline.getInflightInstant(instant,
metaClient.getTableType());
+ revertCompleteToInflight(instant, inflight);
Review comment:
how do such reverts work now? we just seem to delete the complete instant
and it will for e.g make it inflight again? is delete() atomic in cloud stores?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
