nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r354041802
########## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java ########## @@ -51,6 +52,11 @@ // TODO: On by default. Once stable, we will remove the other mode. public static final String BLOOM_INDEX_BUCKETIZED_CHECKING_PROP = "hoodie.bloom.index.bucketized.checking"; public static final String DEFAULT_BLOOM_INDEX_BUCKETIZED_CHECKING = "true"; + public static final String BLOOM_INDEX_FILTER_TYPE_PROP = "hoodie.bloom.index.filter.type.prop"; Review comment: There are lot of properties with suffix "PROP" BLOOM_INDEX_TREE_BASED_FILTER_PROP BLOOM_INDEX_BUCKETIZED_CHECKING_PROP and hence I followed the same ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
