nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r358621679
########## File path: hudi-common/src/test/java/org/apache/hudi/common/bloom/filter/TestInternalDynamicBloomFilter.java ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.bloom.filter; + +import org.apache.hadoop.util.hash.Hash; +import org.junit.Test; + +/** + * Unit tests {@link InternalDynamicBloomFilter} for size bounding. + */ +public class TestInternalDynamicBloomFilter { + + @Test + public void testBoundedSize() { + + int[] batchSizes = {1000, 10000, 10000, 100000, 100000, 10000}; + int indexForMaxGrowth = 3; + int maxSize = batchSizes[0] * 100; + BloomFilter filter = new HoodieDynamicBoundedBloomFilter(batchSizes[0], 0.000001, Hash.MURMUR_HASH, maxSize); + int index = 0; + int lastKnownBloomSize = 0; + while (index < batchSizes.length) { + for (int i = 0; i < batchSizes[index]; i++) { + String key = org.apache.commons.lang.RandomStringUtils.randomAlphanumeric(50); + filter.add(key); + } + + String serString = filter.serializeToString(); + if (index != 0) { + int curLength = serString.length(); + if (index > indexForMaxGrowth) { + assert curLength == lastKnownBloomSize; Review comment: fixed the assert. But I didn't feel a need for parametrized since we are testing only dynamic for boundedness once threshold is met. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
