leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360675434
########## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieMetricsConfig.java ########## @@ -50,10 +50,7 @@ // Jmx public static final String JMX_PREFIX = METRIC_PREFIX + ".jmx"; public static final String JMX_HOST = JMX_PREFIX + ".host"; - public static final String DEFAULT_JMX_HOST = "localhost"; Review comment: why remove the default host? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
