leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX
metrics reporter
URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360735257
##########
File path: hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java
##########
@@ -47,7 +48,7 @@ private Metrics(HoodieWriteConfig metricConfig) {
if (reporter == null) {
throw new RuntimeException("Cannot initialize Reporter.");
}
- // reporter.start();
+ reporter.start();
Review comment:
@vinothchandar I noticed that `reporter.start` was annotated before, is
there any other concern? IMHO, call `start` method here is reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
