sev7e0 edited a comment on issue #1130: [HUDI-445]Refactor the codes based on scala codestyle BlockImportChecker rule URL: https://github.com/apache/incubator-hudi/pull/1130#issuecomment-568819888 > > @sev7e0 Hi, thanks for opening this PR and welcome aboard, right now the IDEA will merge relative imports in block automatically, e.g. `import org.apache.spark.sql.{DataFrame, SQLContext, SaveMode}` in `HoodieSparkSqlWriter.scala`, it is very convenient. However, if we enable the BlockImportChecker rule, we may need fix it manually, which would waste some time for developers, a related disscussion would be found https://lists.apache.org/thread.html/d966752dcabd3305a888785944cd1ac2985b17e48d10d1c1abbca1dd%40%3Cdev.hudi.apache.org%3E, So IMHO we would keep the rule as it is before finding a better solution, WDYT? would close the PR and you would work on other scala codestyle rule if you are insterested :) . CC @lamber-ken FYI. > > @sev7e You can choose other scala codestyle rule, this rule this is controversial. Yes, I also think this code style is not convenient for developers. I try to find other validation rules. If you have good suggestions, you can give me a hint. @leesf @lamber-ken
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
