sev7e0 commented on issue #1130: [HUDI-445]Refactor the codes based on scala codestyle BlockImportChecker rule URL: https://github.com/apache/incubator-hudi/pull/1130#issuecomment-568826317 Sorry, I didn't seriously consider this problem yesterday. I think we should turn off this check. It does bring about the problem of multi line introduction, which is inconsistent with the introduction mechanism of idea itself and brings more work to Hudi developers. I refer to several other Scala projects, e.g. `spark` `flink `. None of them use this check rule. now, I'm thinking of adding an explanation, like this. ```xml </check> <!-- ============================rules we don't want================================== --> <!-- It bring about the problem of multi line introduction --> <check level="error" class="org.scalastyle.scalariform.BlockImportChecker" enabled="false"/> </scalastyle> ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
