SteNicholas commented on a change in pull request #1136: [MINOR]Optimize
hudi-cli module
URL: https://github.com/apache/incubator-hudi/pull/1136#discussion_r361345650
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/HoodiePrintHelper.java
##########
@@ -84,7 +84,7 @@ private static String print(Table buffer) {
buffer.getFieldNames().toArray(header);
String[][] rows =
- buffer.getRenderRows().stream().map(l ->
l.stream().toArray(String[]::new)).toArray(String[][]::new);
+ buffer.getRenderRows().stream().map(l -> l.toArray(new
String[0])).toArray(String[][]::new);
Review comment:
This should be pre-size for `toArray` method, and I have already modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
